Robert Raposa
Robert Raposa
Thanks @ormsbee. I think we still have this set for edxapp in Stage, Prod and Edge. I don't think we use it for any of our other workers. However, it's...
Thanks @kdmccormick. I'll also note that https://docs.openedx.org/projects/edx-platform/en/latest/references/featuretoggles.html is a new feature that helps make it less important how consistent we are. I like clarity that leads to consistency, so I...
1. I created https://github.com/openedx/edx-toggles/pull/303 to improve the docs. 2. I think maybe I could just add a comment next to the FEATURES dict about making new toggles top-level and pointing...
@kdmccormick: Some thoughts since we last wrote on the topic: 1. I realized that people often use `ENABLE_` or `DISABLE_` as a prefix to indicate the default value in the...
* With monkey-patching settings as a last resort, is this a solvable problem? I like it better than the linting solution I had in mind, which only stops the leak,...
Linting would be simple if we just put an upper bound on the size of the dict. So, it is possible that we could decide, add linting, document a naming...
@kdmccormick: Good thoughts. I think your proposal is a reasonable alternative, or enhancement, to what is captured in https://github.com/openedx/edx-toggles/issues/290. Yours is a more elegant solution from a readability perspective, as...
@johnnagro: Did you say there is enterprise code that might be lifted for some of this?
[inform] From [DRF throttling docs](https://www.django-rest-framework.org/api-guide/throttling/#custom-throttles): > If the .wait() method is implemented and the request is throttled, then a Retry-After header will be included in the response. It's unclear to...
Clients should be using timeouts. [See docstring](https://github.com/openedx/edx-rest-api-client/blob/97b7e42d3a143f794a272bf566c0cb4ccef783e6/edx_rest_api_client/client.py#L210). Do we need to improve docs (move from README to how-to?) and/or add linting? [See README docs](https://github.com/openedx/edx-rest-api-client/blob/master/README.rst#usage).