fontParts icon indicating copy to clipboard operation
fontParts copied to clipboard

add build-backend to pyproject.toml

Open Alessandro-Barbieri opened this issue 3 years ago • 8 comments

Could you add add build-backend to pyproject.toml?

Alessandro-Barbieri avatar May 14 '22 13:05 Alessandro-Barbieri

More detail (why do you want this, what will it add, etc) and possibly a PR?

benkiel avatar May 18 '22 16:05 benkiel

I believe it's required for PEP 517 tooling and would avoid downstream packagers from having to hack in the info manually.

alerque avatar May 18 '22 17:05 alerque

I need it to move the ebuild of fontparts in the gentoo overlay ::guru to use PEP517 see https://projects.gentoo.org/python/guide/distutils.html#the-pep-517-and-legacy-modes

Alessandro-Barbieri avatar May 18 '22 17:05 Alessandro-Barbieri

Got it. Read that doc, very helpful: do you know which build-background we should be using? Ok if not, I'll sort it out if not.

benkiel avatar May 18 '22 18:05 benkiel

Probably setuptools, as that's what setup.py uses.

justvanrossum avatar May 18 '22 18:05 justvanrossum

@justvanrossum that's my guess to. On figuring it out as we do use setuptools_scm which has wrinkles it seems.

benkiel avatar May 18 '22 18:05 benkiel

Perhaps go pyproject.toml all the way, and only leave a stub setup.py. I'm doing that with a new project and seems to work ok, including setuptools_scm.

justvanrossum avatar May 18 '22 18:05 justvanrossum

My build-system section looks like this:

[build-system]
requires = ["setuptools", "setuptools-scm[toml]"]
build-backend = "setuptools.build_meta"

justvanrossum avatar May 18 '22 19:05 justvanrossum