supervision icon indicating copy to clipboard operation
supervision copied to clipboard
verified publisher icon roboflow

Instance Segmentation Confusion Matrix

Open mayankagarwals opened this issue 2 years ago • 8 comments

Description

Solves for https://github.com/roboflow/supervision/issues/238

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Please use this colab for testing: https://colab.research.google.com/drive/1OKjyH8JmFMROJ97447DUn13p-GDP6dXl Test cases have been added

mayankagarwals avatar Jul 25 '23 08:07 mayankagarwals

Hi @mayankagarwals 👋🏻! Is that code ready for review? It is still marked as draft.

SkalskiP avatar Aug 01 '23 10:08 SkalskiP

Hey @SkalskiP. No, the code is still not complete as I'm waiting for your input on https://github.com/roboflow/supervision/issues/238. There are two different ways we can design the API.

mayankagarwals avatar Aug 01 '23 17:08 mayankagarwals

@mayankagarwals okey I'm rolling that PR over to supervision-0.14.0

SkalskiP avatar Aug 07 '23 14:08 SkalskiP

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 11 '23 11:08 CLAassistant

Hi @kirilllzaitsev @hardikdava @SkalskiP

While the code here is functional, I wanted to ask your opinion on force_masks

Right now I'm assuming if force_masks is passed we will enforce that every detection in the from_detections is accompanied by a mask. The segmentation confusion matrix is computed only when force_masks is passed

mayankagarwals avatar Aug 15 '23 19:08 mayankagarwals

@mayankagarwals hey, this PR should be relevant. force_masks=True refers to the case when the masks are enforced, while if force_masks=False, but the masks are present in annotations ('segmentation' field), they will be parsed since now

kirilllzaitsev avatar Aug 15 '23 20:08 kirilllzaitsev

hi @kirilllzaitsev!

Cool! I guess then it makes sense to provide a segmentation matrix only if force_masks = true.

@kirilllzaitsev @hardikdava Before I wrap up the documentation and tests, can you please go through the PR and let me know if you have any queries or concerns?

mayankagarwals avatar Aug 16 '23 07:08 mayankagarwals

@SkalskiP @hardikdava PR is ready for review. Have added a colab link for testing.

mayankagarwals avatar Aug 18 '23 12:08 mayankagarwals