Schema inconsistencies 2

[SirStone]

Sorry, I've stolen the title from the last closed bug, but the issue is on the same page of that one. I've found about this when I've completed a script that converts your yaml schemas to my nim needs.

The schema results-for-bot.yaml has id bot-results-for-bot.yaml <-- id is different from the file name The schema game-ended-event-for-bot.yaml references for the results to results-for-bot.yaml

I think that the id of the results-for-bot.yaml should be changed in results-for-bot.yaml

[SirStone]

Another one surfing the repo, bullet-hit-bot-event.yaml has a wrong id

[SirStone]

Third one, bot-hit-bot-event.yaml has different id

[flemming-n-larsen]

@SirStone Thank you for reporting this. 🙂👍

I have fixed the issue with this commit: https://github.com/robocode-dev/tank-royale/commit/6acef2909f86daa306d223bb664799cf112fe752

[SirStone]

Thanks, I will wait for the next release to check on this.

I want to add that I think that the hit-by-bullet-event.yaml is missing but is an object used by the API

Maybe logically is not among the messages exchanged between the server and the API but for the sake of script automation without this file others are forced to add it manually in the same code logic

Explanation for all: This event is not sent directly by the server to the bot, the bot-api receives a generic bullet-hit-bot-event.yaml and internally checks if the victimId is equal to the bot assigned id, if the numbers are equals instead of calling a onBulletHit(bulletHitBotEvent) will call onHitByBullet(hitByBulletEvent)

[flemming-n-larsen]

@SirStone Just released 0.24.1 where the schemas are updated.

[SirStone]

Thanks for the update I've tested the new schemas and now I think are ok but for a missing event: hit-by-bullet-event that is generated by the API and not from the Server.

@flemming-n-larsen I was trying to "pull request" but I ended up making a direct push to the main branch...I didn´t know I had this permission...

I've just uploaded a single new file, hope is not an issue. 7db15b4

[flemming-n-larsen]

@SirStone: The changes look good to me. You are right that I just generate the event on the server side. And I guess I do that for a few of the events. But this does not mean that we should leave out the schemas. So I think it is perfectly okay to add it like you did. Thanks. 👍🙂

If I disable the write permission, you will not be able to update the Wiki. But I will remove it now - at least temporarily to avoid accidental writes to main. 😉 Then I will just grant you write permission again late, if needed.

I recommend that you create a fork of Robocode, or create (feature) branches instead of working on main. This also makes it possible to compare changes against the main branch etc. 🙂

[flemming-n-larsen]

@SirStone: I put you in the role: Triage. Let's see how this goes. 😊

[flemming-n-larsen]

Closing this issue now.