GENOVA icon indicating copy to clipboard operation
GENOVA copied to clipboard

insulation_domainogram / subscript out of bounds

Open amodrek opened this issue 3 years ago • 1 comments

Describe the bug Hello, I am encountering an error with the insulation_domainogram() function, It cannot be reproduced with the "Hap1_WT_40k" test data.

To Reproduce Steps to reproduce the behavior:

cuts142 <- load_contacts(signal_path = 'noDox_10k_10000.cool',
    sample_name = "cuts142",
    balancing = 'T',
    colour = "black")

> cuts142
A GENOVA contacts object named 'cuts142' at a resolution of 10 kb.
Contains the following slots:
- MAT   :       Triplet format matrix containing 138849775 informative bins.
- IDX   :       308839 genomic indices in BED format.
- CHRS  :       A vector of 25 chromosome names.
- CENTROMERES:  Locations of 24 centromeres.
This object is assigned the colour 'black'
0 bins are masked.
No chromosomes have been removed.
The data have not been Z-score normalised.
The original data were loaded in as balanced data.
id <- insulation_domainogram(
  cuts142, "chr22:21e6:31e6")

**Error in value[[1L]] : subscript out of bounds**

Expected behavior This issue does not occur when I run test data (Hap1_WT_40k).

Is the issue that I have X, Y, M chromosomes? I tried it without the M chr and had the same error. IF it helps, here is the [[1]] output:

`

cuts142[[1]] V1 V2 V3 1: 1 1 22365.07060 2: 1 2 32986.54329 3: 1 65 2052.50096 4: 1 66 725.29179 5: 1 88 13.29735 ---
138849771: 308803 308803 53.91853 138849772: 308803 308804 58.36051 138849773: 308804 308804 30.32085 138849774: 308804 308805 23.40389 138849775: 308805 308805 144.51891 `

Thank you for any help.

amodrek avatar May 12 '22 02:05 amodrek

Hello, I encountered same error in "compartment_score" step, and I found the chromosome names are different between HiC matrix and bed file, "1" vs. "chr1". I think you can try to remove chr from "id <- insulation_domainogram( cuts142, "chr22:21e6:31e6")", instead of "chr22:21e6:31e6", try "22:21e6:31e6"

Moonriver1988 avatar May 20 '22 16:05 Moonriver1988