staticrypt icon indicating copy to clipboard operation
staticrypt copied to clipboard

Fixed the issue that the input box will be magnified when clicking on it in mobile browser

Open dearDreamWeb opened this issue 1 year ago • 4 comments

dearDreamWeb avatar Sep 29 '24 06:09 dearDreamWeb

Thanks @dearDreamWeb!

I'm on android so I don't see that behavior, which looks a little annoying. I don't want to prevent the user from pinch-zooming if we can help it though, and I think your current solution would prevent it.

It looks like (in the SO question as well) that setting the font-size to 16px in the input prevents this behavior. It's currently at 14px and I think it's an acceptable compromise, even if a little arbitrary from Safari.

It would preserve the ability for the user to zoom. I don't have Safari, could you try and check if that works?

robinmoisson avatar Oct 03 '24 14:10 robinmoisson

I tried it, it's ok

dearDreamWeb avatar Oct 04 '24 14:10 dearDreamWeb

I forgot to delete the configuration added by viewport, I need to try again

dearDreamWeb avatar Oct 04 '24 14:10 dearDreamWeb

It's ok

dearDreamWeb avatar Oct 04 '24 14:10 dearDreamWeb

Thanks for fixing this @dearDreamWeb! I noticed this issue yesterday and was planning on filing a bug. Would it be possible to get this merged in @robinmoisson or does it need additional testing that I could help with?

AndrewHaglund avatar Jan 05 '25 21:01 AndrewHaglund

Just tested it and that looks great to me! Thanks for the good work @dearDreamWeb and thanks for the ping @AndrewHaglund, I'm merging and deploying a patch bump.

robinmoisson avatar Jan 05 '25 21:01 robinmoisson

Done, 3.5.1 is now live on npm :+1:

robinmoisson avatar Jan 05 '25 21:01 robinmoisson