ducker icon indicating copy to clipboard operation
ducker copied to clipboard

Bollard 'connect_with_ssl'

Open cwelsys opened this issue 10 months ago • 2 comments

Implemented logic to enable connecting to remote docker hosts over tls (with self signed certificates ala https://docs.docker.com/engine/security/protect-access/#use-tls-https-to-protect-the-docker-daemon-socket)

source: https://github.com/fussybeaver/bollard?tab=readme-ov-file#ssl-via-rustls

should probably remove/change the unit tests I added since the docker host I use isn't going to be much help for anyone else testing.

cwelsys avatar Apr 08 '25 03:04 cwelsys

This seems to be the same set of changes as #160?

robertpsoane avatar Apr 08 '25 06:04 robertpsoane

This seems to be the same set of changes as #160?

it appears that way.. sorry, im pretty new to this stuff. I made a PR the other day for the fixes to the key event handling. then made this one today. Seems like I didn't properly do the requesting

cwelsys avatar Apr 08 '25 06:04 cwelsys

Codecov Report

Attention: Patch coverage is 74.04580% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/docker/util.rs 76.98% 29 Missing :warning:
src/events/event_loop.rs 0.00% 5 Missing :warning:
Files with missing lines Coverage Δ
src/events/event_loop.rs 0.00% <0.00%> (ø)
src/docker/util.rs 73.20% <76.98%> (+73.20%) :arrow_up:

... and 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 29 '25 16:06 codecov[bot]

This seems to be the same set of changes as #160?

it appears that way.. sorry, im pretty new to this stuff. I made a PR the other day for the fixes to the key event handling. then made this one today. Seems like I didn't properly do the requesting

@cwelsys no problem! Sorry about the delay in getting back to you, haven't given ducker enough love recently

Have hopefully fixed the merge conflicts I caused separately and this should be good to merge once the pipeline finishes

robertpsoane avatar Jun 29 '25 16:06 robertpsoane