Carsten Rohrbach

Results 25 comments of Carsten Rohrbach

@weirdan and you should be able to `return` from inside a try block in a command, having access to block scoped variables

Hi @hymair we stopped using the module at that time in favor of directly spawning the executable.

Can't tell much more as it's some time ago and I do not have access to that code any more. But if I remember correctly, we worked on files as...

What's preventing a merge here? The multipart tests (which should not relate to my fix) are not working but as you can see here, they are not even causing a...

btw we cannot workaround setting a domain as our service is multi-tenant and the express-session middleware does not support this. Created https://github.com/expressjs/session/issues/988 in addition.

I created a failing test here: https://github.com/ladjs/superagent/commit/22f6632d8df6ef08de23ceb19d4a21a5099a1d64

I tried a fix here: https://github.com/ladjs/superagent/compare/master...robaca:superagent:master For some reason the multipart tests are failing for me locally (maybe because of Node version), otherwise looks promising. I didn't check the PR...

btw. I get the same error in supertest. If I use it with my patched version and change one line in supertest/lib/agent.js to `req.on('pre-redirect', this._saveCookies.bind(this))`, it's working for me.

Not sure what changed, but this error didn't occur any more after a while.

With a second clean installation with the same project setup, the error is occurring again, so I reopen the ticket. It would be helpful if I can get DevLake to...