core icon indicating copy to clipboard operation
core copied to clipboard

Retry middleware

Open teandr opened this issue 5 months ago • 2 comments

teandr avatar Aug 17 '25 10:08 teandr

Thanks for the PR! Looks good overall but I have a few comments that need to be addressed first. Please check them out when you find the time.

ksassnowski avatar Aug 20 '25 06:08 ksassnowski

Hi, Kai.

Hope you're having a good week.

I'm writing to follow up on the pull request. I've addressed your previous comments and implemented the array-based backoff strategy, which is a much cleaner approach – thank you for the suggestion.

The implementation now allows a backoff option (e.g., [1, 5, 10]) to define the retry delays in seconds.

It then pushes this value into the request's options under the delay key.

Guzzle itself, as per its documentation, is responsible for honoring this option and pausing before sending the next request.

This approach delegates the actual waiting to the HTTP client, which is a best practice.

Would you mind reviewing the updated implementation when you get a chance? I believe it now cleanly combines the flexible configuration you suggested with the robust execution provided by Guzzle.

Please let me know if you have any further questions or if there's anything else you'd like to see adjusted.

Thank you for your time !

teandr avatar Aug 27 '25 15:08 teandr