core icon indicating copy to clipboard operation
core copied to clipboard

Update ExecuteJavascriptMiddleware.php by allowing config of waitUntilNetworkIdle()

Open josezenem opened this issue 2 years ago • 2 comments

This pull request introduces an additional improvement to #56 by allowing the configuration of waitUntilNetworkIdle(). The previous implementation assumed the true statement, making it impossible to overwrite this behavior without duplicating the class, which I ran into for a particular project.

To address this, a new config variable called waitUntilNetworkIdle has been introduced. By default, the config is set to true to maintain backward compatibility with the original pull request. However, you now have the flexibility to overwrite the setting and set it to false.

josezenem avatar Jan 24 '24 23:01 josezenem

Sorry for the delay.

Looks good to me, thanks for the contribution! Can you rebase your changes on top of main and push again? There's a small merge conflict due to some recent changes I've made.

ksassnowski avatar Jan 28 '24 20:01 ksassnowski

Of course, no problem thank you! i have updated and pushed, thanks again.

josezenem avatar Jan 30 '24 02:01 josezenem