Rick Newton-Rogers comments

Results 18 comments of


                                            Rick Newton-Rogers

Request: Make CMS-related objects public

Thanks for sharing those details. I think we have a change coming soon to make those available behind SPI.

CI: Add build check for WebAssembly SDK

@FranzBusch Do you continue to have reservations about this PR?

CI: Add build check for WebAssembly SDK

>[Invalid workflow file: .github/workflows/pull_request.yml#L96](https://github.com/apple/swift-nio/actions/runs/16599692246/workflow) error parsing called workflow ".github/workflows/pull_request.yml" -> "apple/swift-nio/.github/workflows/wasm_sdk.yml@main" : failed to fetch workflow: workflow was not found. I think we'll have to merge the re-usable workflow in...

getaddrinfo resolver throws away error code

Thanks for filing the issue - this makes sense, we should do it.

Provide a current user home directory API in FileSystem

Thanks for the issue Tim, I'm curious do you currently have any workarounds for this, is it blocking any functionality?

Provide a current user home directory API in FileSystem

Thanks for the context 🙏

Disable Xcode-beta builds until one is installed

> I'm not sure why the matrix still generated a job for Xcode-latest here. Is it explicitly using the version committed to the base branch instead of the version I...

docs: `String(buffer:)` needs to mention that it will always succeed

Thanks for highlighting this, it looks like we should do this. I see that the underlying `readString` method which is used does have some related docs https://github.com/apple/swift-nio/blob/6e02c7a2467cf22526ac54521d4230d8c5890e62/Sources/NIOCore/ByteBuffer-aux.swift#L290 .