maps icon indicating copy to clipboard operation
maps copied to clipboard

Android Official Example - mapview v10 - can't display compass & scaleBar (Even though I set scaleBarEnabled={true})

Open HAIHAI211 opened this issue 3 years ago • 10 comments

image

HAIHAI211 avatar Jun 20 '22 06:06 HAIHAI211

I'm having the same problem, in my case compassEnable={false} doesn't work.

TIEverton avatar Jun 20 '22 18:06 TIEverton

v10 is still a work in progress, and scalebar is not working yet for android.

felixgourdeau avatar Jun 22 '22 02:06 felixgourdeau

@felixgourdeau I'm using v8 and having this same problem.

portugaAndre avatar Jun 22 '22 12:06 portugaAndre

@react-native-mapbox-gl+maps+8.5.0.patch.txt

@portugaAndre We are using v8 still (moving to v10 soon hopefully) and built this patch to fix a few issues. Scale bar is fixed and can be enabled/disabled. The compass on Android is fixed and we hardcoded it to always show instead of fading out. It also fixes the deprecated ViewPropTypes issue with RN0.69.0. Hope it helps!

mysport12 avatar Jul 07 '22 14:07 mysport12

Is it disabling as expected ?

Em qui., 7 de jul. de 2022 às 11:19, Craig Martin @.***> escreveu:

@react-native-mapbox-gl+maps+8.5.0.patch.txt https://github.com/rnmapbox/maps/files/9064545/%40react-native-mapbox-gl%2Bmaps%2B8.5.0.patch.txt

@portugaAndre https://github.com/portugaAndre I am using v8 still (moving to v10 soon hopefully) and this is the patch I am using. Scale bar is working in our app

— Reply to this email directly, view it on GitHub https://github.com/rnmapbox/maps/issues/1990#issuecomment-1177691063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO6ESUBWIWWXBZKO7CZEY53VS3RPHANCNFSM5ZHXFKRQ . You are receiving this because you were mentioned.Message ID: @.***>

portugaAndre avatar Jul 07 '22 14:07 portugaAndre

Truth be told, we always have the compass and scale bar enabled so I haven't tested the disabling side of the functionality in quite some time. But to get both to render the patch works

mysport12 avatar Jul 07 '22 15:07 mysport12

both are working here, the problem is we need to disable it. XD

Em qui., 7 de jul. de 2022 às 12:08, Craig Martin @.***> escreveu:

Truth be told, we always have the compass and scale bar enabled so I haven't tested the disabling side of the functionality in quite some time. But to get both to render the patch works

— Reply to this email directly, view it on GitHub https://github.com/rnmapbox/maps/issues/1990#issuecomment-1177763244, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO6ESUGCXE4E25BBYNEYIFTVS3XFFANCNFSM5ZHXFKRQ . You are receiving this because you were mentioned.Message ID: @.***>

portugaAndre avatar Jul 07 '22 19:07 portugaAndre

Compass settings added in #2036

mfazekas avatar Jul 11 '22 05:07 mfazekas

Actually we are using compassEnabled = False, but it's not working. Sometimes it works, but sometimes it doesn't.

Em seg., 11 de jul. de 2022 às 02:14, Miklós Fazekas < @.***> escreveu:

Compass settings added in #2036 https://github.com/rnmapbox/maps/pull/2036

— Reply to this email directly, view it on GitHub https://github.com/rnmapbox/maps/issues/1990#issuecomment-1179974665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO6ESUGZOQ5UZGC4MDDPGH3VTOUSJANCNFSM5ZHXFKRQ . You are receiving this because you were mentioned.Message ID: @.***>

portugaAndre avatar Jul 11 '22 11:07 portugaAndre

I saw you just merged with master. I'll try again.

Em seg., 11 de jul. de 2022 às 08:36, André Vinicius Andrade < @.***> escreveu:

Actually we are using compassEnabled = False, but it's not working. Sometimes it works, but sometimes it doesn't.

Em seg., 11 de jul. de 2022 às 02:14, Miklós Fazekas < @.***> escreveu:

Compass settings added in #2036 https://github.com/rnmapbox/maps/pull/2036

— Reply to this email directly, view it on GitHub https://github.com/rnmapbox/maps/issues/1990#issuecomment-1179974665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO6ESUGZOQ5UZGC4MDDPGH3VTOUSJANCNFSM5ZHXFKRQ . You are receiving this because you were mentioned.Message ID: @.***>

portugaAndre avatar Jul 11 '22 11:07 portugaAndre

It sounds like a few people in this thread are actually having trouble getting the scale bar to disable in v10 (which is affecting our app as well). I created a new issue specifically for the ability to disable scale bar in v10: https://github.com/rnmapbox/maps/issues/2295.

arcticfly avatar Oct 13 '22 22:10 arcticfly

Scale bar should be addressed now

mfazekas avatar Oct 16 '22 06:10 mfazekas