Implement `Span::Log()` using annotations

[jmcomets]

I noticed no field logging was implemented and therefore implemented it using the same ideas as zipkin-go-opentracing.

[rnburn]

Thanks @jmcomets - I'd be glad to have this functionality added in.

I'll try to review this soon.

[rnburn]

Could you add some coverage for this into https://github.com/rnburn/zipkin-cpp-opentracing/blob/master/zipkin_opentracing/test/ot_tracer_test.cc#L129?

[rnburn]

@jmcomets I actually had setValue use non-string values at one point, but I changed it to strings because the non-strings broke jaeger's zipkin compatibility mode.

According to https://github.com/openzipkin/zipkin/issues/939#issue-131157141, non-string binary annotations aren't really supported.

[jmcomets]

Thanks for the info, I wasn't sure when writing it. I'm off for the next few weeks and won't be able to look more into it.

On Fri, Apr 20, 2018, 18:18 Ryan [email protected] wrote:

@jmcomets https://github.com/jmcomets I actually had setValue use non-string values at one point, but I changed it to strings because the non-strings broke jaeger's zipkin compatibility mode.

According to openzipkin/zipkin#939 (comment) https://github.com/openzipkin/zipkin/issues/939#issue-131157141, non-string binary annotations aren't really supported.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rnburn/zipkin-cpp-opentracing/pull/18#issuecomment-383147777, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzmg4cWTMMCIQ26NStKazdWByOGpy2Rks5tqgo9gaJpZM4TTgtw .