Rano | Ranadeep
Rano | Ranadeep
There are a few `Result::ok()` calls in the source code - a few of them are redundant, and a few of them are used wrongly. 1. We convert `Option` to...
The following `Options` (indicates failure to decode) are subsumed by parent `Option` from `.set`/`.get` ` (indicates unset path in the store) https://github.com/informalsystems/basecoin-rs/blob/dc3b43a4f9e8015897b8a896b9cddd6a56ed8ae0/crates/store/src/types/store.rs#L56 https://github.com/informalsystems/basecoin-rs/blob/dc3b43a4f9e8015897b8a896b9cddd6a56ed8ae0/crates/store/src/types/store.rs#L68 The `C::encode` calls are correctly `.unwrap`-ed in...
Just like [`AnyConsensusState`](https://github.com/informalsystems/basecoin-rs/blob/25d86e6c2a2dc3472e718b045597a7c4bd37dff7/crates/app/src/modules/ibc/impls.rs#L86-L92), we should use `AnyClientState`. This was not possible before because the `ClientState` derive macro didn't take relevant type bounds for `IbcContext`. When the next `ibc` version is...
Currently, [`get_packet_commitment`](https://github.com/informalsystems/basecoin-rs/blob/aa59797863272119a7bcb63bdf13b6d037dcd5cf/crates/app/src/modules/ibc/impls.rs#L515-L531) returns the commitment stored at a commitment path. But this commitment may not be valid - as [`delete_packet_commitment`](https://github.com/informalsystems/basecoin-rs/blob/aa59797863272119a7bcb63bdf13b6d037dcd5cf/crates/app/src/modules/ibc/impls.rs#L712-L717) may have set it to empty. This leads to transaction...
MDX tests take too long to set up OCaml and to build `ocaml-mdx-test` binary. If the caches are not hit, [it takes 11 mins on ubuntu and 20 mins on...
Async runtime provides a friendlier interface to handle concurrent tasks. Python's [`asyncio`](https://docs.python.org/3/library/asyncio.html) library reduces the code burden and offers more straightforward methods. The main cost is tagging methods with `async`...
- [ ] Issue templates - [ ] Pull request template - [ ] dependabot.yml Ref: https://github.com/devspace/awesome-github-templates
- Runs jobs in docker container https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container - Uses pre-built https://github.com/rnbguy/mdx-docker - GitHub workflow mounts standard directories in non-standard places in docker, which messes up with some github-actions - macOS...
Closes #111 Example usage, ``` atomkraft init transfer cd transfer atomkraft chain remote gh:cosmos/cosmos-sdk --ref v0.45.8 ... atomkraft test trace ... ```