Steamworks.NET icon indicating copy to clipboard operation
Steamworks.NET copied to clipboard

Disable RedistInstall when DISABLESTEAMWORKS is defined

Open TheCrossBoy opened this issue 10 months ago • 2 comments

Right now, the STEAMWORKS_NET define is always added to the scripting defines.

If steamworks is disabled with DISABLESTEAMWORKS or because it isn't compatible with the platform, it should not be added.

Guards the file in constant bounds to check for the define.

Fixes #656

TheCrossBoy avatar Apr 04 '25 22:04 TheCrossBoy

Additionally, I think it's relevant to mention that the current release (2024.8.0) does not use the version of RedistInstall.cs that it should have been at the time:

https://github.com/rlabrecque/Steamworks.NET/blob/2024.8.0/com.rlabrecque.steamworks.net/Editor/RedistInstall.cs

It's using a much older version of the file, which has an additional bug in more recent versions.

TheCrossBoy avatar Apr 04 '25 22:04 TheCrossBoy

I've created this other PR with a setting to avoid it from adding the defines at all: #712

sandolkakos avatar Jun 06 '25 05:06 sandolkakos

With #712 merged in, let me know if we're still missing any piece of this

rlabrecque avatar Jul 12 '25 23:07 rlabrecque