BBHash icon indicating copy to clipboard operation
BBHash copied to clipboard

`std::iterator` is deprecated

Open adamnovak opened this issue 7 months ago • 0 comments

In C++17, inheriting from std::iterator is deprecated, on the theory that code is actually better if it just explicitly defines all the typedefs that std::iterator would get you by inheritance.

But it is still used e.g. here: https://github.com/rizkg/BBHash/blob/1803c2325afab8ad045c94ef7872a319bc44a5e5/BooPHF.h#L45

This leads to compiler warnings when compiling under C++17 or later.

adamnovak avatar Jul 10 '25 17:07 adamnovak