Rishit Chaudhary
Rishit Chaudhary
Hi @cleder, I'm interested in working on this issue. Can you please assign it to me? Thanks
Hi @cleder, I want to update you that I'm working on this. Progress is a bit slow, but I hope to have an initial patch soon. Thanks
Hi @cleder, > Can you document how to do it? For me, it is obvious, so I need an outsider's view on it to improve the documentation 😉 Sure, I...
Hi @cleder, In the file `fastkml/times.py`, `TimeSpan` already optionally accepts a `begin` and `end` of type `Optional[KmlDateTime]`, so I think that sub-task is already taken care of, correct?
@cleder, also the new classes `When`, `Begin`, and `End` must derive from `_TimePrimitive` so that they can access the `super()._get_kwargs` and `super().etree_element` methods, correct?
Sounds good, I'll put up my draft PR in the next hour 👍
Hi @cleder, My draft PR is up 🎉 --- Also, here's the current checklist status of my PR: - [x] Add new classes `When`, `Begin` and `End` - [x] Remove...
Hi @cleder, I took a look at the changes in https://github.com/cleder/fastkml/commit/6e4dba115107b403af88afe0fc073cfe6f52afdc and the changes look good 👍 I'll learn more about the codebase to work on issues faster next time....