iSTFTNet-pytorch icon indicating copy to clipboard operation
iSTFTNet-pytorch copied to clipboard

Does anyone know why parameters of C8C1I increases?

Open TrilSiaWalt opened this issue 1 year ago • 3 comments

Snipaste_2024-08-17_22-06-50 Does anyone know why parameters of C8C1I increases? I try to mainly modify the config as

    "upsample_rates": [8, 1],
    "upsample_kernel_sizes": [16, 15],

or

    "upsample_rates": [8, 1],
    "upsample_kernel_sizes": [16, 1],

but neither of their parameters changed as shown in the table.

TrilSiaWalt avatar Aug 17 '24 14:08 TrilSiaWalt

inspecting what you are trying to do, it should be more like:

"upsample_rates": [8,1], "upsample_kernel_sizes": [16,2],

though that alone won't be enough, you also need to update the iSTFT parameters gen_istft_n_fft and gen_istft_hop_size so you get perfect upsampling to 256 samples per frame

SynthAether avatar Aug 17 '24 16:08 SynthAether

inspecting what you are trying to do, it should be more like:

"upsample_rates": [8,1], "upsample_kernel_sizes": [16,2],

though that alone won't be enough, you also need to update the iSTFT parameters gen_istft_n_fft and gen_istft_hop_size so you get perfect upsampling to 256 samples per frame

had done that. you can see that C8I also need it but it doesn't increase the parameters.

TrilSiaWalt avatar Aug 18 '24 01:08 TrilSiaWalt

they give reason in iSTFTNet2 paper:

Param of iSTFTNet-C8C1I32 is larger than that of iSTFTNetC8C8I4 because the number of channels is halved in the second 1D ResBlocks in iSTFTNet-C8C8I4, whereas it is not conducted in iSTFTNet-C8C1I32 owing to the absence of temporal upsampling. We used this strategy to confirm whether iSTFTNet-C8C1I32 could not obtain comparable speech quality, even with expressive modules.

NorthhhFishSoup avatar Jan 18 '25 09:01 NorthhhFishSoup