Rishi Gupta

Results 78 comments of Rishi Gupta

When you look at this, the things that would be most helpful: * How should the RealmAuditLog migration be done? Should I add a new column, copy stuff over, and...

Thanks! It does look like json keys are always strings (and ujson.dumps automatically does the conversion from int->str). I agree RealmAuditLog.ROLE_COUNT and similar can just be '10' if needed. How...

First three commits are ready for review, and include the main RealmAuditLog sync.

cool! Yeah, I think the current set of commits might be good to test/harden on czo before 2.1. The next set of commits will be zulipchat.com specific, so don't need...

This is ready for review. Two comments about the first commit: * The migration technically only needs to run on zulipchat.com realms, so possibly doesn't need to be checked in...

The errors are just migration numbering conflicts. Let me know if it would be helpful to fix them.

I think just linkedin (along with the existing twitter and github).