explorer icon indicating copy to clipboard operation
explorer copied to clipboard

Ledger Metrics

Open golobitch opened this issue 3 years ago • 2 comments

High Level Overview of Change

Added feature for showing ledger metrics per XRPLBounties #18

Following was added:

  • Number of successful transactions
  • Number of failed transaction
  • Breakdown of transactions by type
  • Summaries of the amount of ledger objects by type: AccountRoot (account), Offer, Escrow, RippleState (trust line), PayChannel, etc.

Context of Change

This is a new feature or better yet, an improvement of existing XRPL data As already pointed out in previous section, this is a part of XRPLBounties #18.

Type of Change

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Tests (You added tests for code that already exists, or your new feature included in this PR)

TypeScript/Hooks Update

  • [ ] Updated files to React Hooks
  • [ ] Updated files to TypeScript

I did not try to modernise the codebase. It is already quite a big change and I did not want to introduce too much change in one PR. This can be done in the future.

Before / After

BEFORE 2022-09-16-ledger-metrics-before

AFTER 2022-09-16-ledger-metrics-after

Test Plan

I updated existing tests. I have mocked ledger_data ledger response and check if there is correct number of cols, if there is ledger index on correct place, that there is before and after links / arrows, etc.

There is one point that was not implemented

  • A special call-out (icon) if there are no tecINVARIANT_FAILED transactions

This can be done in the future or as the part of this PR, but this special call-out icon needs to be provided.

Notes

SCSS code was taken from some already open PR

golobitch avatar Sep 16 '22 19:09 golobitch

The categories of transactions will be DEX, Account, Payment, NFT, XChain, and Pseduo-TX

ckniffen avatar Sep 19 '22 18:09 ckniffen

I have removed code regarding ledger state objects, due to complexity of the issue and also to not block approve & merge of transaction ledger statistics (Milestone 1)

golobitch avatar Sep 20 '22 18:09 golobitch

@golobitch please review the comments above.

If you do not update this PR or reply within 7 days, this PR may be closed due to inactivity. If that occurs, you can still open a new PR that addresses the comments above.

intelliot avatar Apr 05 '23 15:04 intelliot

@golobitch please review the comments above.

If you do not update this PR or reply within 7 days, this PR may be closed due to inactivity. If that occurs, you can still open a new PR that addresses the comments above.

This work was put on hold.

ckniffen avatar Apr 05 '23 15:04 ckniffen

@ckniffen what's the next step for this PR? Should it be closed?

intelliot avatar Sep 19 '23 04:09 intelliot

@ckniffen what's the next step for this PR? Should it be closed?

Nothing. We decided to hold off until more css was cleaned up. Will close for now.

ckniffen avatar Sep 19 '23 19:09 ckniffen