explorer icon indicating copy to clipboard operation
explorer copied to clipboard
verified publisher icon ripple

Add Myanmar language

Open usaikoo opened this issue 1 year ago • 3 comments

High Level Overview of Change

Added support for the Myanmar language, including translation files, updates to the language selector, and necessary backend adjustments for proper localization.

Context of Change

This change introduces the Myanmar language to the app's localization system.

  • New Feature: Added support for Myanmar to cater to users in that region.
  • Architecture: This was integrated into the existing i18n framework without any major architectural changes.
  • Alternatives: Other alternatives like creating a separate app for Myanmar were considered but rejected for cost and maintenance reasons.

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (non-breaking change that only restructures code)
  • [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation Updates
  • [x] Translation Updates
  • [ ] Release

TypeScript/Hooks Update

  • [ ] Updated files to React Hooks
  • [ ] Updated files to TypeScript

No TypeScript or React Hooks updates in this PR, as it primarily focuses on translation files and language selector.

Before / After

Before

  • The application did not support the Myanmar language.
  • Language dropdown excluded Myanmar.

After

  • Myanmar language translations added to explorer/public/locales/my-MM/translations.json.
  • Myanmar option now available in the language dropdown.
  • Backend supports Myanmar-specific content and language preferences.

Test Plan

  • Verified Myanmar language rendering on all UI components through manual testing.
  • Ran tests to ensure the system behaves as expected with the newly added language.
  • Checked the language switcher functionality to confirm the Myanmar language appears in the dropdown and functions properly.
  • Add automated tests for verifying new translations.
  • Update documentation with steps for adding new languages.

usaikoo avatar Jan 22 '25 03:01 usaikoo

@usaikoo you can update the branch and merge this PR now. Thanks for your contribution!

pdp2121 avatar Jan 30 '25 16:01 pdp2121

@usaikoo I will merge with staging now if you dont mind

pdp2121 avatar Feb 20 '25 16:02 pdp2121

@usaikoo I will merge with staging now if you dont mind

Yes please merge.Thank you so much.

usaikoo avatar Feb 23 '25 19:02 usaikoo