squirrel icon indicating copy to clipboard operation
squirrel copied to clipboard

Comment alignment

Open a8568730 opened this issue 5 years ago • 4 comments

Overview

Align all comments according to the max length of candidates.

Before After
截圖 2020-11-26 上午11 43 54 截圖 2020-11-26 上午11 22 54

a8568730 avatar Nov 26 '20 09:11 a8568730

Use a cannot guarantee alignment, whereas the space between candidate and comment becomes variable. Besides, did you test for linear mode? I doubt it will ruin linear mode.

LEOYoon-Tsaw avatar Nov 26 '20 15:11 LEOYoon-Tsaw

Weasel for rime also has comment alignment.

Did you mean horizontal mode as linear mode? The code checks if now it is vertical mode, only the vertical mode will be calculated, leaving the horizontal mode.

截圖 2020-11-27 上午9 59 59

Also thank you for that I found the candidate list style config has change style/horizontal to style/candidate_list_layout at https://github.com/rime/squirrel/commit/88e085a6e4fc778a7208e193c86f04d3e61c3b48, I should follow the new config.

a8568730 avatar Nov 27 '20 02:11 a8568730

I also suggest making it configurable, I don’t feel I’m going to use it, I don’t want to be forced

LEOYoon-Tsaw avatar Nov 27 '20 04:11 LEOYoon-Tsaw

Actually users may add a tab to comment to achieve the same results. Perhaps there’s no need to change the code at all.

LEOYoon-Tsaw avatar Nov 27 '20 05:11 LEOYoon-Tsaw

This can be closed, as new candidate_format explicitly let user choose the character between candidate and comment. If the user wish so, they can use [candidate]\x09[comment]

LEOYoon-Tsaw avatar May 28 '24 17:05 LEOYoon-Tsaw