pyquil icon indicating copy to clipboard operation
pyquil copied to clipboard

ErfSquareWaveform zeros_right should be calculated using pad_right

Open bramathon opened this issue 4 years ago • 0 comments

Pre-Report Checklist

  • [x] I am running the latest versions of pyQuil and the Forest SDK
  • [x] I checked to make sure that this bug has not already been reported

Issue Description

The ErfSquareWaveform is not using the pad_right property, pad_left is used to compute both paddings.

in quiltwaveforms.py at line 270:

        zeros_left = np.zeros(int(np.ceil(self.pad_left * rate)), dtype=np.complex128)
        zeros_right = np.zeros(int(np.ceil(self.pad_left * rate)), dtype=np.complex128)

bramathon avatar Oct 05 '21 23:10 bramathon