rig icon indicating copy to clipboard operation
rig copied to clipboard

CLI improvements for better CI/CD

Open blacksails opened this issue 1 year ago • 3 comments

The CLI needs to be improved to give a nice experience in CI

  • [x] #709
  • [x] #723
  • [x] Improve configuration
    • [x] #707
    • [x] #706
  • [ ] #708
  • [x] #710
  • [x] #711

blacksails avatar Mar 08 '24 12:03 blacksails

When non-interactive (no terminal on stdin), we expect a RIG_CLIENT_ID and RIG_CLIENT_SECRET to be present, if no config file exists.

andersjohnsen avatar Mar 11 '24 08:03 andersjohnsen

When non-interactive (no terminal on stdin), we expect a RIG_CLIENT_ID and RIG_CLIENT_SECRET to be present, if no config file exists.

I would rather say we expect credentials to be configured in the rig config file, but we let flags/env vars be ways of overriding their values.

When loading the config

  1. Load the config file
  2. Override from flags
  3. Override from envvars

Which then makes for the full config.

blacksails avatar Mar 11 '24 08:03 blacksails

That's in effect what's happening - but this way we allow running without a config file.

andersjohnsen avatar Mar 11 '24 08:03 andersjohnsen