robotframework-extendedselenium2library icon indicating copy to clipboard operation
robotframework-extendedselenium2library copied to clipboard

Update for renamed modules in Selenium2Library

Open davidshepherd7 opened this issue 8 years ago • 3 comments

In the (unreleased) tip version of Selenium2Library some modules have been renamed to remove the leading underscore. I needed to use the tip version so I made the changes, and I figured you'll need to update at some point so I may as well pull request them for when you do.

Hope it saves you a bit of time :+1:

davidshepherd7 avatar Apr 03 '17 10:04 davidshepherd7

Thank you, @davidshepherd7. Would you please fill in the CLA located here: https://goo.gl/forms/1pkl9YfWpA . Thanks.

rickypc avatar Apr 07 '18 16:04 rickypc

Ok, done :+1:

davidshepherd7 avatar Apr 07 '18 17:04 davidshepherd7

I look at this deeper, Selenium2Library was going through larger architecture changes in order to ease future maintenance. We need to inherit SeleniumLibrary differently, hence it could be a new extended library completely. At this point I'm facing personal issue that required a lot of my time, hence I don't have much time available to invest to bring it up to latest SeleniumLibrary unfortunately. I will freeze the Selenium2Library version requirement at 1.8.0 to make sure this library still functional. I'll keep this PR open, and I sincerely appreciate your contribution @davidshepherd7.

rickypc avatar Apr 08 '18 20:04 rickypc