consul-client icon indicating copy to clipboard operation
consul-client copied to clipboard
verified publisher icon rickfast

checkWatch networkReadMillis < cacheWatchSeconds ?

Open ecolinet opened this issue 4 years ago • 1 comments

Hi,

I don't understand why the networkReadTimeout is enforced to be higher than the cacheWatch value. Shouldn't it be the opposite ?

https://github.com/rickfast/consul-client/blob/b0c56fc1ca7f9320ad67bd5860dd49245251f115/src/main/java/com/orbitz/consul/cache/ConsulCache.java#L411-L416

Thanks, Eric

ecolinet avatar Jul 29 '21 13:07 ecolinet

I think https://github.com/rickfast/consul-client/pull/453 will address this

ElfoLiNk avatar Nov 29 '21 12:11 ElfoLiNk