react-snap-carousel icon indicating copy to clipboard operation
react-snap-carousel copied to clipboard

Fixed prev method behavior for custom data-should-snap attribute defined logic

Open dzebisati opened this issue 1 year ago • 3 comments

Continue of the disscution in #34

When user defines own "page" logic via data-should-snap attribute, in some cases prev method stop working as expected.

Demo with examples on sandbox

dzebisati avatar Dec 31 '24 09:12 dzebisati

@richardscarrott, any plans to close this, or did you stop maintaining the lib?

KasperAndersson avatar Sep 17 '25 07:09 KasperAndersson

@KasperAndersson tbh I'm a little unsure I want to maintain support for data-should-snap as it's adding more complexity than I anticipated and I'm not completely sold on the feature — it was originally added to help me experiment with infinite carousels a while back and is undocumented.

Are you experiencing the same issue and does this PR solve it for you?

richardscarrott avatar Sep 17 '25 08:09 richardscarrott

Hi @richardscarrott ,

We'ven't actually used the option, as it hasn't been required by our design. We're currently undergoing some re-implementations that require us to use the data-should-snap attribute, and we're now experiencing the same issue that this PR solves. Tried using this branch, and it fixes the problem with prev button casually being unresponsive.

Thanks

KasperAndersson avatar Sep 23 '25 08:09 KasperAndersson