rgthree-comfy icon indicating copy to clipboard operation
rgthree-comfy copied to clipboard

Node Combiner breaks the workflow and ComfyUI.

Open myusf01 opened this issue 1 year ago • 1 comments

After adding Node Combiner node by accident my workflow and Comfy has broken. You can't delete the node, change workflow or anything else the only solution is attempting to uninstall rgthree package but even that is not fixing the problem because rgthree is not being uninstalled but a fallback workflow is being loaded somehow and everything is normal, if it stays on one of the workflows it's breaking again. This is a very time consuming bug because I'm getting confused by the names every time I'm trying to load Node Collector.

This is the log when I try to load another workflow:

Loading aborted due to error reloading workflow data

TypeError: Cannot set properties of undefined (setting 'removed')
TypeError: Cannot set properties of undefined (setting 'removed')
    at onRemoved (http://127.0.0.1:8001/extensions/rgthree-comfy/base_node.js:129:22)
    at object.<computed> (http://127.0.0.1:8001/extensions/cg-use-everywhere/use_everywhere_utilities.js:259:19)
    at CombinerNode.onRemoved (http://127.0.0.1:8001/assets/index-Hblmz8kc.js:172579:23)
    at LGraph2.clear (http://127.0.0.1:8001/assets/index-Hblmz8kc.js:90566:26)
    at app.graph.clear (http://127.0.0.1:8001/extensions/ComfyUI-Manager/comfyui-manager.js:1472:15)
    at LGraph2.configure (http://127.0.0.1:8001/assets/index-Hblmz8kc.js:91575:25)
    at LGraph$1.configure (http://127.0.0.1:8001/assets/index-Hblmz8kc.js:223992:26)
    at LGraph.configure (http://127.0.0.1:8001/extensions/comfyui-custom-scripts/js/reroutePrimitive.js:14:29)
    at ComfyApp.loadGraphData (http://127.0.0.1:8001/assets/index-Hblmz8kc.js:224234:18)
    at async app.loadGraphData (http://127.0.0.1:8001/extensions/ComfyUI-Manager/components-manager.js:774:9)
This may be due to the following script:
/extensions/rgthree-comfy/base_node.js

myusf01 avatar Apr 16 '25 13:04 myusf01

Looking at the error I don't think this is specific to the Node Combiner. It looks like a duplicate of https://github.com/rgthree/rgthree-comfy/issues/453 which was a bug in ComfyUI filed here: https://github.com/Comfy-Org/ComfyUI_frontend/issues/3248

I think the fix has made it's way to ComfyUI main, tough. Have you updated your ComfyUI and it's Frontend recently?

rgthree avatar Apr 19 '25 01:04 rgthree