faerun-python icon indicating copy to clipboard operation
faerun-python copied to clipboard

Faerun produces invalid tree coordinates in create_python_data()

Open grayver opened this issue 3 years ago • 0 comments

Hello! Thanks for all your work and Faerun library!

I've discovered that Faerun.create_data() which produces JS output and Faerun.create_python_data() which produces Python output have different tree coordinates. It seems to be there is a problem with scale, because when you open saved *.faerun file in the hosted mode - the tree has different scale comparing to scatter plot.

I've investigated it a little bit and found the cause - in create_python_data() method the same variable s is used for the scale:

s = self.scale

and for the iterator:

for s in range(len(data[mapping["c"]])):

P.S. also there is a problem generating HTML output on Windows when you have unicode characters in your labels. This seems to be output file encoding issue.

grayver avatar Nov 07 '22 01:11 grayver