ngx-jsonapi icon indicating copy to clipboard operation
ngx-jsonapi copied to clipboard

'&' in remotefilter is not properly URL serialized

Open lunarmoon26 opened this issue 4 years ago • 1 comments

Version:

2.2.1

Issue:

For example giving the following service call:

Service<Resource>.all({
  remotefilter: {
    field: "foo&bar"
  }
})

The serialized URL will be:

...?filter[field]=foo&bar

which isn't correct. The work around is to manually encrypt the string before passing to the filter. This isn't very robust as the developer may forget to do so

Solution:

URL encrypt the string field (encodeURIComponent) by default and provide an option to override?

lunarmoon26 avatar Apr 16 '21 07:04 lunarmoon26

Solution:

  • URL encrypt the string field (encodeURIComponent) by default

PR with jest test are welcome. On 15 days, if the problem has not been solved, @ahumadamatias will fix it (FE-261).

pablorsk avatar Apr 16 '21 11:04 pablorsk