AgentGPT icon indicating copy to clipboard operation
AgentGPT copied to clipboard

😵 Update settings logic

Open asim-shrestha opened this issue 3 years ago • 3 comments

So advanced settings features are only available if a user provides their own API key. We also perform some client side validation to ensure the API key provided by the client is correct.

The issue is, is this validation always runs regardless of whether or not the user changes any settings. This means the user can

  • Open settings
  • Do nothing
  • Click save
  • Get "Key is invalid, please ensure that you have set up billing in your OpenAI account!" when they didn't change anything

This is confusing for users. We should place the model selection within advanced settings as well and just gray it out if no api key is provided. We shouldn't run this validation if the user doesn't touch the API key

asim-shrestha avatar Apr 25 '23 00:04 asim-shrestha

@asim-shrestha , is this still an issue?? if yes then I can fix this. can you please assign me?

abhithory avatar Jun 29 '23 16:06 abhithory

Hello @abhithory this issue as been resolved as we added a new validation system and new settings component!!

jasangill1 avatar Jun 29 '23 21:06 jasangill1