AgentGPT icon indicating copy to clipboard operation
AgentGPT copied to clipboard

Has this project been published on Docker Hub?

Open Passerby1011 opened this issue 3 years ago • 10 comments

Has this project been published on Docker Hub? I want to deploy it on my NAS, and it would be much easier if it has been published on Docker Hub.

Passerby1011 avatar Apr 14 '23 15:04 Passerby1011

Not yet, this is something we can get done soon hopefully!

awtkns avatar Apr 14 '23 15:04 awtkns

Would

Not yet, this is something we can get done soon hopefully!

Would you consider to support it in railway.app by the way?

theend777 avatar Apr 15 '23 03:04 theend777

Not yet, this is something we can get done soon hopefully!

I do plan to work on a Github Actions workflow that builds the image and publishes it to the Github Container registry.

Personally, I would recommend using the GitHub Container Registry over Dockerhub as it offers easier integration.

exil0867 avatar Apr 15 '23 04:04 exil0867

Github would be even better! We can likely support both in the future. Ty @exilvm

awtkns avatar Apr 15 '23 04:04 awtkns

we need pull image from docker hub, coz failure when build from setup.sh --docker, it's so sad

xinmans avatar Apr 15 '23 08:04 xinmans

I tried to install this project with docker which is included in the code, when i was messing around trying to understand what each part did I ran debugger and it said docker was including in the package but hadn't been installed, it ask if I wanted to install it an di said yes, worst mistake of my life the docker stopped win1 from starting and after hours of troubleshooting I ended up restoring windows.

DMTarmey avatar Apr 17 '23 10:04 DMTarmey

This project has not been shared on docker hub yet unfortunately. I'm sorry to hear that about your windows!

awtkns avatar Apr 17 '23 11:04 awtkns

@awtkns @asim-shrestha Hello! i've been kind of busy lately but i'm working on the Docker builder/publisher workflow however it was nearly impossible with the current Dockerfile since it doesn't correctly handle the different (and required) environment variables between development/production which often causes validation errors (see https://github.com/reworkd/AgentGPT/issues/147#issuecomment-1509851210). So i believe the Docker Multi-stage feature is the way to go, and also using docker compose files in favor of .env and .env.docker.

You can check the changes in my fork: https://github.com/reworkd/AgentGPT/compare/main...exilvm:AgentGPT:main docker-compose.dev.yml (that targets the development stage) works well and it does replace the --docker code-block in setup.sh.

I haven't had enough time to work on the production stage so it is not finished yet but at some point it did run without errors, but it does need more testing.

The workflow also needs to be configued to target the different stages.

I don't know how long this will take me since i'm busy with studying and working on other side-projects.

Any feedback is appreciated please let me know if my approach is right.

I'm also considering opening it as a draft pull request so i can get more feedback.

exil0867 avatar Apr 17 '23 13:04 exil0867

Hey @exilvm, we've since update our docker compose so this may be a touch outdated now. Would love to see all of that in a draft PR and we can evaluate further. Thanks for the help!

asim-shrestha avatar May 10 '23 23:05 asim-shrestha

Hey @exilvm, we've since update our docker compose so this may be a touch outdated now. Would love to see all of that in a draft PR and we can evaluate further. Thanks for the help!

Hello! I'm not updated with the recent changes in the project so my draft PR is probably outdated. I was not able to find any free time to work on it (or maintain any of my side projects) due to my final year exams. I'm still planning to continue working on it though. Thanks.

exil0867 avatar May 11 '23 04:05 exil0867