graphql-builder icon indicating copy to clipboard operation
graphql-builder copied to clipboard
verified publisher icon retro

Add deps.edn and fix compose fn

Open CHNB128 opened this issue 5 years ago • 4 comments

CHNB128 avatar May 30 '20 12:05 CHNB128

Hey, thank you for this PR. I see that you've added deps.edn . Since this project is using leiningen can you remove deps.edn for now, and ensure that the deps are managed through project.clj .

If there is a reason to switch to deps.edn, I would be ok with it, but I don't have too much experience (yet) with the publishing process using deps.edn, so please add another PR for that.

retro avatar Jun 01 '20 17:06 retro

Hi,deps.ednneed to use library in clojurescript projects, wich can't be or not yet supported lein. So for better compability I suggest to support it as well. And about splitting deps file into different pr, yeah, it make sense.

CHNB128 avatar Jun 07 '20 08:06 CHNB128

And sorry for the trash in commits. I don't wont to merge them all in context of this pr. I just not well familiar with GitHub flow of merge over fork. I just added some of them for my purpoces, without any desire to add include they there.

CHNB128 avatar Jun 07 '20 08:06 CHNB128

To be honest, I have big load on work, so I haven't time to clean this pr. Sorry for that. If you need some of they, I think you can cherry pick they.

CHNB128 avatar Jun 07 '20 08:06 CHNB128