resque
Ajaxify retry and remove links in Failure queue. Prevent expensive p…
I'd love to hear some feedback on this PR.
The goal was to remove the expensive cycle of reloading the page for each job that has been removed from the failure queue. Often I've found that this cycle of removing or retrying with a reloading of the page can take much too long on an overloaded queue. Ideally this PR would shorten the cycle of getting bad jobs out of the queue by reducing the long load cycle.
Coverage increased (+0.03%) to 83.39% when pulling 4ab4d5228e3f3be6e2dae2abddc45ca92543a725 on knappe:Ajaxify-Remove-Retry-Links into 10f2d2e328843487c5dd251a010dffd6a3b10f8e on resque:master.
This looks to have failed (only) on Ruby 2.2 to install sqlite3.
An error occurred while installing sqlite3 (1.3.8), and Bundler cannot continue.
Thanks for your PR! It looks great.
Unfortunately I probably won't have time to try this out properly anytime soon.
Could anyone else contributing PR's to this project perhaps give a :+1: ? @mattgibson @kirillplatonov
Coverage increased (+0.03%) to 83.39% when pulling 9b3acc7aa4b9e0c766bcd98159aca033926be18f on knappe:Ajaxify-Remove-Retry-Links into 10f2d2e328843487c5dd251a010dffd6a3b10f8e on resque:master.
One thing of note here.
I had some trouble testing this out because mocking out a Resque::Failure for the full stack gave me some trouble. I'd appreciate it if someone check if this works well for a legitimate failure.
That failure is the same on that I ran into. Bundle update fixes it. I'll make a PR later to do a bundle update for master, which should fix it for all PRs. Will take a look at the code properly then.
Coverage increased (+0.03%) to 83.93% when pulling 0a23909ac89e7fc5c4543330059d75769adf228f on knappe:Ajaxify-Remove-Retry-Links into 389f448bdd60bdbec6399d3ee2e5adc9243d01b2 on resque:master.
Coverage increased (+0.03%) to 83.93% when pulling 0a23909ac89e7fc5c4543330059d75769adf228f on knappe:Ajaxify-Remove-Retry-Links into 389f448bdd60bdbec6399d3ee2e5adc9243d01b2 on resque:master.
@mcfiredrill @mattgibson Just checking in. It has been month since I last checked.
@mcfiredrill @mattgibson @kirillplatonov PR has been ready since May, any chance I could get someone to take a look at it?
As much as I hate them, a browser driven test is probably needed here since it is Javascript.
Must the Javascript be part of the view? Can we not separate out into its own asset perhaps?
I'll take a look at what this does for real, and comment on the code directly as well
