resque-scheduler Fix `gethostbyaddr` deprecation warnings

Use supported Addrinfo APIs to get the fully qualified local host name.

Sep 21 '22 05:09 irvingreid

After a fair bit of local debugging, I suspect this test failure is flaky? I could only reproduce it when I had another instance of resque-scheduler attached to my Redis server.

Sep 21 '22 19:09 irvingreid

Hey I think this is probably okay to sneak into a patch release. Would you mind removing the gemspec changes? The gemspec changes aren't required for this fix.

Oct 06 '22 22:10 PatrickTulskie

Would you mind removing the gemspec changes? The gemspec changes aren't required for this fix.

@PatrickTulskie done, thanks for reviewing!

Oct 07 '22 17:10 irvingreid

Hey it looks like those commits are still in this branch. Can you remove the out of scope commits instead of just reverting them? I can also do a merge but the rebase with a single clean commit is better. Gonna aim to get in a point release next week.

Oct 13 '22 19:10 PatrickTulskie

Ah OK. We usually do squash merges here, so we don't fuss about the branch being noisy :-)

Oct 13 '22 19:10 irvingreid

Sorry about the delay - I got tricked by Github not syncing the upstream and origin master branches quite the way I expected, and couldn't figure out why the test was failing (and couldn't figure out how to re-run that one test case without pushing a change - is that possible with this CI setup?)

Oct 20 '22 04:10 irvingreid

@PatrickTulskie looks like this should be good to go now -- one commit as requested, and checks are passing. Can you please add this to a coming release for Ruby 3 compatibility?

Jan 19 '23 02:01 oehlschl

Sorry about the delay merging this. Was dealing with an end of quarter crunch. Anyhow, it's in gem v4.8.0 shipped just now.

Jan 27 '23 17:01 PatrickTulskie