resque-scheduler icon indicating copy to clipboard operation
resque-scheduler copied to clipboard

Use non-deprecated form of Redis.sadd/srem

Open irvingreid opened this issue 3 years ago • 1 comments

This fixes the deprecation warnings for Redis#sadd and Redis#srem output by version 4.8 of redis-rb, following the example of the changes made to Resque in https://github.com/resque/resque/pull/1827

Other tests failed when upgrading redis-rb to 5.0.4, which is why I added the restriction to resque-scheduler.gemspec

To avoid future regressions, I enabled Redis.raise_deprecations = true so that the test suite is more likely to catch future Redis deprecations.

irvingreid avatar Sep 21 '22 05:09 irvingreid

Looks like your test matrix pairs Redis 4.8 with older versions of the resque gem, which trigger deprecation failures. Would you rather change the test matrix, or remove Redis.raise_deprecations = true?

irvingreid avatar Sep 21 '22 05:09 irvingreid

@PatrickTulskie removed the gemspec change here too, because the main branch fixed Redis 5.0 compatibility :-)

irvingreid avatar Oct 07 '22 17:10 irvingreid

Friendly bump. Is there anything preventing this from getting merged?

carlwiedemann avatar May 08 '23 16:05 carlwiedemann