resque-scheduler icon indicating copy to clipboard operation
resque-scheduler copied to clipboard

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

Open seb-sykio opened this issue 3 years ago • 5 comments

I have this deprecation with Resque.remove_delayed

` Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do redis.get("key") end

should be replaced by

redis.pipelined do |pipeline| pipeline.get("key") end

Redis::Namespace.pipelined(&block#Proc) at .rvm/gems/ruby-3.1.1/gems/redis-namespace-1.8.2/lib/redis/namespace.rb:301 Resque::DataStore.method_missing(sym#Symbol, *args#Array, &block#Proc) at .rvm/gems/ruby-3.1.1/gems/resque-2.2.1/lib/resque/data_store.rb:65 Resque::Scheduler::DelayingExtensions.remove_delayed_job(encoded_job#String) at .rvm/gems/ruby-3.1.1/gems/resque-scheduler-4.5.0/lib/resque/scheduler/delaying_extensions.rb:302 Resque::Scheduler::DelayingExtensions.remove_delayed(klass#Class, *args#Array) at .rvm/gems/ruby-3.1.1/gems/resque-scheduler-4.5.0/lib/resque/scheduler/delaying_extensions.rb:150`

seb-sykio avatar Apr 06 '22 11:04 seb-sykio

This is already in the master branch

https://github.com/resque/resque-scheduler/commit/cb3e9f6aa6b520609a8c223a7e11f31f6c2c361c

cody-elhard avatar Apr 07 '22 14:04 cody-elhard

It looks like deprecation warnings are still happening in CI on the latest master (though not related to this gem, those warnings are coming from dependencies - see https://github.com/resque/redis-namespace/issues/193 / https://github.com/resque/resque/issues/1794)

codealchemy avatar Apr 07 '22 20:04 codealchemy

Hi, When I was doing scheduler job, it is still happening. (Even I installl the gem from github master branch) Could anyone help me figure out?

resque-scheduler: [INFO] 2022-04-10T18:53:00+08:00: queueing SendReminder (send_reminder)
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

(called from /Users/rileykao/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/redis-namespace-1.8.2/lib/redis/namespace.rb:530:in `namespaced_block'}

chinyakao avatar Apr 10 '22 10:04 chinyakao

@chinyakao Now resque/resque#1806 has been merged into master branch, so I think you could suppress the warnings by using the master resque-scheduler and resque.

I'm looking forward to the release of new versions of both gems.

mishina2228 avatar Jun 25 '22 01:06 mishina2228

@mishina2228 Thank you so much!

chinyakao avatar Jun 25 '22 13:06 chinyakao

@seb-sykio (Cc: @PatrickTulskie, @iloveitaly) resque v2.3.0 (the latest is v2.4.0) and resque-scheduler v4.6.0, which address this issue, has already been released. So I believe we can close this issue.

mishina2228 avatar Sep 19 '22 14:09 mishina2228

@mishina2228 Got it. Closing this out. Thanks!

PatrickTulskie avatar Sep 19 '22 14:09 PatrickTulskie