rescript-react icon indicating copy to clipboard operation
rescript-react copied to clipboard
verified publisher icon rescript-lang

React 18 support

Open tom-sherman opened this issue 4 years ago • 1 comments

Closes #34

This PR includes a small amount of formatting in src/React.res, I can remove that commit if #36 is merged first.

Marked as draft until React 18 is released.

  • [x] useSyncExternalStore
  • [x] ~~Uncurried version of hooks~~ Likely not needed, let me know if they are
  • [x] Tests

tom-sherman avatar Dec 19 '21 18:12 tom-sherman

@rickyvetter I think the only blocker on merging this is https://github.com/rescript-lang/rescript-react/pull/35#discussion_r839220770 - would you agree?

Also what do you think about removing the useSES bindings for now?

And shall we do uncurried bindings in a followup? Just so that #46 is unblocked.

tom-sherman avatar Jun 09 '22 10:06 tom-sherman

What's made this PR blocked? I was waiting for react 18 binding so long!

hackwaly avatar Sep 08 '22 07:09 hackwaly

See PPX v4: https://github.com/rescript-lang/rescript-react/pull/49/files#diff-46efb9fafbbb11cf26bd8ac10f0bc5df02ac0e42f593b87cce382e712b8cf950R15

Seems like a good place for this to go.

cristianoc avatar Sep 08 '22 08:09 cristianoc

The issue is currently there's nobody specifically maintaining rescript-react per se. So pinging from time to time, as @hackwaly just did, could help things move along.

cristianoc avatar Sep 08 '22 08:09 cristianoc

@tom-sherman Thanks a lot for your contribution! 👍

I will close this PR as we are finishing the work in #46.

cknitt avatar Sep 29 '22 05:09 cknitt