app icon indicating copy to clipboard operation
app copied to clipboard

Add additional debugging output

Open jftanner opened this issue 3 years ago • 4 comments

This PR adds some debugging output for when context.config returns an empty object (or null). This resulted from #566, where I had neglected to set GHE_HOST so Octokit called public Github instead of GHE. Hopefully this debugging helps future users identify the same situation.

jftanner avatar May 02 '22 19:05 jftanner

@jftanner is attempting to deploy a commit to the Probot Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 02 '22 19:05 vercel[bot]

is there documentation that would be worth linking to in this log output that would have given hints toward why the config was unable to be read?

travi avatar May 04 '22 04:05 travi

That's a good question. This is the relevant documentation: https://probot.github.io/docs/configuration/

Though, maybe I should add an additional check that verifies that the URLs in the webhook payload match GHE_HOST variable. That'd be a known failure state with a known fix, whereas there might be other reasons why context.config might fail.

jftanner avatar May 05 '22 15:05 jftanner

I've added that change. Unfortunately, I can't test it properly because I'm stuck on an unrelated problem with ESM.

jftanner avatar May 05 '22 16:05 jftanner