replit
Update julia.toml
@dan-stowell @amasad Can we get a merge on this? Julia 1.5 is out but I'm bumping this incrementally.
@logankilpatrick can you you set the PRYBAR_TAG in the Dockerfile to circleci_pipeline_89_build_96, run make test-julia, then push that commit and I'll merge?
What dir do I have to be in to run that command? Running from the root does not work (I am a big Docker noob).
What dir do I have to be in to run that command? Running from the root does not work (I am a big Docker noob).
From the polygott dir, you can run make test-julia and it should build a julia image & run the tests.
Okay, it should be good:
Successfully built 8ff8b7cdc88c
Successfully tagged polygott-julia:latest
docker run polygott-julia bash -c polygott-self-test
✓ julia:hello
Wonderful, once this goes through, I will open the PR to bump to the latest Julia version (v1.5).
@logankilpatrick just checking in here -- is the test failure related to your change?
It worked again when I tested locally:
Successfully built 2922b9ce9d41
Successfully tagged polygott-julia:latest
docker run polygott-julia bash -c polygott-self-test
✓ julia:hello
The tests are also failing due to permission issues (according to the build) due to me not being a collaborator on this repo maybe?
Good afternoon @logankilpatrick ! You've probably noticed by now that we've been slow to merge community PRs on polygott. We've decided to focus on giving Repl.it a stable foundation instead of adding features and updating languages. Once we and our community feel comfortable with Repl.it's overall stability, we'll give this change another look. This change, in particular, should be straightforward to get over the finish line. Thank you for contributing!
Hey all, any update on this? Would be great if Repl.it supported the most recent Julia version.
@logankilpatrick, apologies for the long delay on a straightforward pull request. We've been focused on overall Replit stability the past few months. We're now in a position to roll out clearly beneficial Polygott changes. https://github.com/replit/polygott/pull/185 upgrades to 1.4.1 (the build should be green on that branch), and then we can look at getting to 1.5.3 right after that.
@logankilpatrick I merged https://github.com/replit/polygott/commit/dcdaa0ff51114d3725fc036540e9eb6506afd15f over the weekend. It'll go out with the next polygott release this week. I'll leave this PR open to update you on when it's rolling out.
Great! @dan-stowell if we merge in Julia 1.5.3, can we get that in for the release? I can submit a Pr tonight.
@logankilpatrick Julia 1.4.1 is out if you create a new julia_beta repl: https://repl.it/l/julia_beta
(The console header says 1.3.1, but if you run julia --version in the shell you'll see it's actually 1.4.1. I'm pushing a config change to correct the console header shortly.)
And, yes! If you open a pull request upgrading to Julia 1.5.3, we can release that next. It'd be most helpful to get a pull request up against prybar (much like I did for the Julia 1.4.1 upgrade): https://github.com/replit/prybar/pull/52 followed by the PR on polygott.
Great, just opened PR’s in both places. Thanks again!
On Feb 10, 2021, at 6:27 AM, Dan Stowell [email protected] wrote:
@logankilpatrick https://github.com/logankilpatrick Julia 1.4.1 is out if you create a new julia_beta repl: https://repl.it/l/julia_beta https://repl.it/l/julia_beta (The console header says 1.3.1, but if you run julia --version in the shell you'll see it's actually 1.4.1. I'm pushing a config change to correct the console header shortly.)
And, yes! If you open a pull request upgrading to Julia 1.5.3, we can release that next. It'd be most helpful to get a pull request up against prybar (much like I did for the Julia 1.4.1 upgrade): replit/prybar#52 https://github.com/replit/prybar/pull/52 followed by the PR on polygott.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/replit/polygott/pull/89#issuecomment-776743753, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIPN5XQIMGCYQF4XFXXWBXLS6KJTVANCNFSM4M4GS4PQ.
I think PR #220 and https://github.com/replit/prybar/pull/52 mean this PR is obsolete. And there is also PR #222 by now
