ship
ship copied to clipboard
ship init does not work with Gitlab URL
Expected behavior
ship init https://gitlab.com/charts/gitlab should not create an empty project
Actual behavior
ship init https://gitlab.com/charts/gitlab creates an empty project
Information
- Command line run:
https://kubernetes.slack.com/archives/CFFKXV0JZ/p1560780271024900
$ ship init https://gitlab.com/charts/gitlab/tree/master
Reading https://gitlab.com/charts/gitlab/tree/master ...
Determining application type ...
Attempting to retrieve upstream https://gitlab.com/charts/gitlab/tree/master ...
Detected application type k8s
Looking for ship.yaml ...
ship.yaml not found in upstream, generating default lifecycle for application ...
Open browser to continue? (Y/n) y
Opening console at http://localhost:8800 ...
Steps to reproduce the behavior
-
ship init https://gitlab.com/charts/gitlab/tree/master
@areed ship init git::https://gitlab.com/charts/gitlab/ works - we just need the git:: annotation for go-getter.
If GitLab follows the same URL schema as GitHub does, we should add handling for that though (parsing /tree/master/bin as using ref=master and within subdir=/bin)