Jakub Theimer
Jakub Theimer
> @theimerj are you able to fix the conflicts? Thx Yeah sure, done.
Ok, I will add the tests shortly.
Hey @glennjacobs, I added some tests. Just tell me if you want to test for anything else.
Hello @glennjacobs, I fixed the tests, the whole suit should now run ok. I came across a problem when I could not run the tests at all, which seems to...
@LeonBuchner on our projects we use it just like this: ```yaml SESSION_DOMAIN=.domain.com SANCTUM_STATEFUL_DOMAINS=.domain.com ``` Also please double check that you set up everything correctly following the docs: [https://laravel.com/docs/10.x/sanctum#installation](https://laravel.com/docs/10.x/sanctum#installation)
This change https://github.com/lunarphp/lunar/commit/edb019fe38356896178faac23658ae8ff90cc2fc was the missing piece to get green in our projects.
I know this PR is huge, but here is the gist. I basically went through the whole codebase and did just a few things: 1. Replace concrete model implementations in...
> @theimerj Looks like there was some overlap with a PR, are you able to take a look at the conflicts? Hey @alecritson, I will get to it soon. Thank...
1. Ok, I understand your concern, but Lunar's responsibility is to ensure that it always resolves the correct concrete implementation. To me it basically seems wrong to use concrete implementations...
Hello @alecritson, thank you for your reply. > I think you're correct in the sense that Lunar should be able to resolve the concrete class, but the underlying core code...