xrnx icon indicating copy to clipboard operation
xrnx copied to clipboard

Incorrect range for vertical_zoom_factor (sample)

Open snabeljoel opened this issue 7 years ago • 2 comments

Renoise allows setting this value between 0.0 and 1.999... It was incorrectly specified as 0-1.

(The error message in Renoise is similarly incorrect)

snabeljoel avatar Jul 17 '18 13:07 snabeljoel

Hi, and sorry for the late response! I just checked and nothing seems wrong. Renoise accepts a 0-1 range. Try setting it to something else and you will get the following error:

std::logic_error: 'invalid vertical_zoom_factor value '2'. valid values are (0 to 1).'

bjorn-nesby avatar Apr 17 '19 11:04 bjorn-nesby

Try setting it to 1.99. Renoise accepts 0-1.999, but not 2... (hence why I wrote "-> [number >= 0.0 < 2.0]")

I think the commit is valid, but maybe you want to fix this in Renoise instead of updating the docs.

snabeljoel avatar Apr 17 '19 17:04 snabeljoel