webpacker-react
webpacker-react copied to clipboard
Proper caching and mounting with Turbolinks 5
Fixes #27
Changes:
Follow the pattern of react-rails and always mount components on turbolinks:load whether initial HTML exists or not.
Please ensure that:
- [ ] Changelog is updated if not a minor patch
- [ ] Ruby linting is ok:
rubocopis all green - [ ] Javascript linting is ok:
cd javascript/webpacker_react-npm-module/ && yarn lintis all green - [ ] Tests are all green
I'm not really sure why the specs are failing... It seems webpack is compiling just fine so I'm not sure why webpacker is having issues finding the manifest.json.
By forcing webpacker to previous commit SHAs I can see that webpacker#a858f8e causes things to break