gcode-preview icon indicating copy to clipboard operation
gcode-preview copied to clipboard

React demo does not support react-scripts 5

Open Nxtmind opened this issue 2 years ago • 1 comments

image

Updating react scripts will lead to errors. package.json#L15 "react-scripts": "4.0.3" -> "react-scripts": "5.0.1"

Additionally, react-scripts: 4.0.3 does not play nice with node >16 and requires a additional flag in the start script. react-scripts --openssl-legacy-provider start

Nxtmind avatar Aug 21 '23 05:08 Nxtmind

Hi @Nxtmind! Thanks for reporting this. Unfortunately I have little React knowledge. I gave it a try but I cannot figure out how to fix this. Although the error appears the moment the GCodePreview.tsx is loaded. (found out by commenting it out temporarily).

I googled the error message but it seems to relate to cases where components are declared using class syntax. But all react components in this demo are functions so I don't understand it.

Btw, I did get react-scripts 4 to work with Node 18 (which is LTS). Maybe this is of some help to you. I've bumped .nvmrc in any case.

I'll leave this open in case anyone, me or anyone else, wants to dig deeper at some point. Any additional insights on this issue are much appreciated.

remcoder avatar Aug 21 '23 15:08 remcoder