gcode-preview icon indicating copy to clipboard operation
gcode-preview copied to clipboard

Move the drag and drop code

Open sophiedeziel opened this issue 1 year ago • 1 comments

Should we un-deprecate the drag and drop option?

The _enableDropHandler() method could be moved outside of WebGLPreview.

sophiedeziel avatar Oct 16 '24 22:10 sophiedeziel

I'd be for undeprecating DnD. We could probably use something like a a dom-utils module or canvas wrapper class to organize things like DnD and resizing.

remcoder avatar Oct 17 '24 08:10 remcoder

petition to rename 'allowDragNDrop' to dnd. So you can just set the option dnd : true..

or another option: droppable: true.

remcoder avatar Jan 14 '25 22:01 remcoder

I vote droppable!

I'm not a fan of using acronyms in APIs, unless documentation is using the long form. The thing is, even when an acronym is widely known, someone may need to google it to know what it means. I18n is easy to find the meaning for, but dnd could mean a lot of things.

sophiedeziel avatar Jan 23 '25 23:01 sophiedeziel