gcode-preview icon indicating copy to clipboard operation
gcode-preview copied to clipboard

WIP Refactor responsibilities out of WebGLPreview

Open sophiedeziel opened this issue 1 year ago • 6 comments

This is a POC for splitting the codebase into smaller classes

sophiedeziel avatar Jun 23 '24 22:06 sophiedeziel

Visit the preview URL for this PR (updated for commit 90eaa04):

https://gcode-preview--pr169-refactor-poc-object-y4dpcans.web.app

(expires Sat, 27 Jul 2024 12:04:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531

github-actions[bot] avatar Jun 23 '24 22:06 github-actions[bot]

oh! this is a great improvement! A very neat and straightforward reorg. Very happy to see this direction 🙌🏻

remcoder avatar Jun 28 '24 11:06 remcoder

Another thing that could be split off is all the preview settings (colors, min/max layer etc).

remcoder avatar Jun 28 '24 16:06 remcoder

Good idea!!

I'm using that branch as a POC, and opened a draft PR to facilitate visualization and conversations.

I'll split in smaller PRs when we're happy about some individual changes and confident about them

sophiedeziel avatar Jun 28 '24 20:06 sophiedeziel

And another idea might be to split line rendering and tube rendering into separate rendering classes.... ?

remcoder avatar Jun 28 '24 21:06 remcoder

Of course! That's the next step!

sophiedeziel avatar Jun 28 '24 22:06 sophiedeziel

What do we want with this PR? It's part clean up and part parser redesign. And it has a lot of conflicts. May I propose to close this one?

remcoder avatar Oct 09 '24 19:10 remcoder

Yes, let's close. The other PR is in a better state.

sophiedeziel avatar Oct 10 '24 01:10 sophiedeziel