react-markdown icon indicating copy to clipboard operation
react-markdown copied to clipboard

Fixing `string[]` scenario

Open jonathandewitt-dev opened this issue 1 year ago • 3 comments

Initial checklist

  • [x] I read the support docs
  • [x] I read the contributing guide
  • [x] I agree to follow the code of conduct
  • [x] I searched issues and couldn’t find anything (or linked relevant results below)
  • [x] If applicable, I’ve added docs and tests

Description of changes

This addresses issue #854 by adding support for string[] in addition to string children.

jonathandewitt-dev avatar Aug 25 '24 22:08 jonathandewitt-dev

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2245c64) to head (517bb29). Report is 10 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #855   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines         1354      1410   +56     
  Branches       113       115    +2     
=========================================
+ Hits          1354      1410   +56     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 25 '24 22:08 codecov-commenter

I think this only adds ambiguity. We can better make it clear that we only accept a string. If you have an array of strings you want to join together using newlines, you can write that in your own code.

remcohaszing avatar Aug 26 '24 08:08 remcohaszing

Thanks but lets first discuss the issue more: https://github.com/remarkjs/react-markdown/issues/854.

wooorm avatar Aug 26 '24 09:08 wooorm

resolved at https://github.com/remarkjs/react-markdown/issues/854#issuecomment-2337579770

ChristianMurphy avatar Sep 12 '24 14:09 ChristianMurphy

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

github-actions[bot] avatar Sep 12 '24 14:09 github-actions[bot]