regulus79

Results 170 comments of regulus79

I found a solution to the warnings by simply removing the parameter from the signal and instead having each editor query the current position of the timeline themselves. The connections...

Okay, this is difficult. **Originally**, I had it so that `Timeline` emitted `Timeline::positionChanged` whenever `Timeline::setPlayPos` or `Timeline::setTicks` was called. `Timeline::positionChanged` was then connected to all the editors with a `Qt::QueuedConnection`....

Partially following sakertooth's suggestion, I have removed `PlayPos.h` from the PR. Now each `Timeline` stores it's own `TimePos` along with a frame offset and `jumped` variable. I have also removed...

I had to make some minor changes to fix the position line update its position when scrolling or zooming the piano roll/song editor. Previously, it appears we were relying on...

> What's the status of this now? Is it ready for review again? I believe I left off still working/thinking of a good way to keep the millisecond timer working...

Ok I just realized since #7759 doesn't actually get rid of the detuning editor, this is still technically a bug. Let me know if you want me to reopen this.

Sure! I'll reopen this, but I will likely remove the portion of this PR which edits the default zoom, since although that is useful, it gets complicated because the editor...

I believe the loop is unidirectional, but it's just hard to hear when the slices are so short. Here's an example with longer slices: https://github.com/user-attachments/assets/b15aeff9-405d-457c-8011-413999a4dd01

Closing, as the SlicerT UI has significantly changed, and a looping option would probably need to be discussed in more detail before implementing it.