reframe icon indicating copy to clipboard operation
reframe copied to clipboard

[feat] Add new `sched_bind_options` environment configuration option for emitting environment-specific scheduler options

Open ekouts opened this issue 2 years ago • 3 comments

Closes #2991.

I am a bit confused by a comment from @vkarak in the issue:

Just to be clear, the above syntax is proposed for the partition definition.

Why would these options be defined in the partition?

ekouts avatar Dec 12 '23 11:12 ekouts

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2023-12-19 21:24:51 UTC

pep8speaks avatar Dec 12 '23 11:12 pep8speaks

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8a8ce63) 86.63% compared to head (2f6537c) 86.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3078      +/-   ##
===========================================
- Coverage    86.63%   86.62%   -0.01%     
===========================================
  Files           61       61              
  Lines        12041    12047       +6     
===========================================
+ Hits         10432    10436       +4     
- Misses        1609     1611       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 12 '23 11:12 codecov[bot]

I was about to merge this, but read this and the original issue:

Why would these options be defined in the partition?

@ekouts Yes, it was proposed to be in the environs because it's a partition's property how you should bind the environment and not the environment's.

I'm removing it from 4.5 as we need to understand what's the best way to implement it.

vkarak avatar Dec 20 '23 09:12 vkarak